Fix for commands regarding missing product updates cause of bulk size…

Sylius / SyliusElasticSearchPlugin

DEPRECATED! Use https://github.com/BitBagCommerce/SyliusElasticsearchPlugin instead.

22 stars 26 forks source link

Fix for commands regarding missing product updates cause of bulk size… #78

Closed PatrickJuergens closed 6 years ago

PatrickJuergens commented 6 years ago

In both commands

bin/console sylius:elastic-search:reset-product-index --force
bin/console sylius:elastic-search:update-product-index

there is a commit bulk size of 100 documents. If there are less than 100 products or even a rest than there is no commit for these product documents.

JanTvrdik commented 6 years ago

Isn't this already handled by $this->elasticsearchManager->commit(); after the foreach?

PatrickJuergens commented 6 years ago

Yes, you are right there is a commit after the foreach at ResetProductIndexCommand. Sorry my fault, i will fix it. But there is no commit at the end of the UpdateProductIndexCommand

pamil commented 6 years ago

Looks like Travis build finally got restarted :)

pamil commented 6 years ago

Thanks @PatrickJuergens! 🎉