search

Sylius / SyliusResourceBundle

Simpler CRUD for Symfony applications
https://sylius.com
MIT License
214 stars 155 forks source link

[Maintenance] Deprecate unused configuration nodes #861

Open NoResponseMate opened 3 months ago

NoResponseMate commented 3 months ago
Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Related tickets -
License MIT

From what I see these nodes were never in use.

NoResponseMate commented 2 months ago

@diimpp Just rechecked. There's no problem when it's missing in regards to Sylius, it's not in use per se, and if it's additionally added to Order configuration, for instance, it makes no difference since it's a new node with no connection to the Resource one. There is an issue though, when someone sets the options in their yaml config; the container will fail to build since the node is no longer there. No idea why someone would use this node since it's not consumed in any way, but either way just to be safe I'll deprecate it instead.