search

Sylius / SyliusResourceBundle

Simpler CRUD for Symfony applications
https://sylius.com
MIT License
219 stars 155 forks source link

Fix state machine tag #871

Closed Zales0123 closed 4 months ago

Zales0123 commented 4 months ago
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

👋 As Sylius introduced the state machine layer abstraction with its own sylius.state_machine service tag, we have a little conflict of configuration, which prevents using SyliusResourceBundle with Sylius 1.13 for now :dancer: (see this issue)

For now, I propose we change the tag in this repository to sylius_resource.state_machine (which is also semantically more correct), but we should probably think if there is any thing we need to do on this repo according to this state machine abstraction 🖖

lchrusciel commented 4 months ago

Thank you, @Zales0123!

GSadee commented 4 months ago

Adding to the context, in Sylius/Sylius, the state machine from Resource is overridden to use abstraction (https://github.com/Sylius/Sylius/pull/16051), so there is probably no need for any other changes here. Unless we would like to use the StateMachineAbstraction package here 🤔