SyliusCrafts / BootstrapTheme

Sylius Bootstrap theme with build process based on Webpack Encore
94 stars 56 forks source link

Update to Bootstrap 5 #120

Closed bartek-sek closed 10 months ago

bartek-sek commented 1 year ago

Hi,

I work for BitBag company, and I’d like to suggest updating the Bootstrap version to Bootstrap 5. Additionally, I’ve come across a few issues that I believe need attention. To address these issues and the update, I’ve prepared a pull request with the necessary changes.

Here’s a summary of the proposed changes:

  1. Bootstrap update

    • Due to conflict with bootstrap 5, I wanted to ask you, if it is ok to remove bootstrap.native library. Having both bootstrap 5 and bootstrap.native imported causes some components not work properly (e.g. dropdown).
  2. Bugfixes

    • Fixed error 500 for search and filters (Sylius 1.12) - if there is at least one element in search result it throws error 500
    • Fixed error 500 for address book (Sylius 1.12) - if you delete address from address book it throws error 500
    • Fixed missing mobile taxon menu - the condition for displaying mobile menu was never met
    • Added missing images (footer and error pages)

You can view the pull request with the proposed changes here: #121

I would greatly appreciate it, if you could review and consider these changes. If you have any questions or suggestions, please don’t hesitate to let me know.

Additionally, if you prefer, I can split the bug fixes into separate pull requests to make the review process more manageable and modular.

Best regards, Bartek from BitBag