search

SyliusCrafts / BootstrapTheme

Sylius Bootstrap theme with build process based on Webpack Encore
94 stars 57 forks source link

Macro "calculateOriginalPrice" is not defined and Variable "applied_promotions" does not exist #125

Open zefyx opened 3 weeks ago

zefyx commented 3 weeks ago

Hello, first thank you for maintaining this project.

After installing your recent version v1.1.0 in a new Sylius v1.13.1 we found two small issues. Macro "calculateOriginalPrice" is not defined in template "@SyliusShop/Common/Macro/money.html.twig". Differences : https://github.com/Sylius/Sylius/blob/v1.13.1/src/Sylius/Bundle/ShopBundle/Resources/views/Common/Macro/money.html.twig https://github.com/SyliusCrafts/BootstrapTheme/blob/v1.1.0/templates/bundles/SyliusShopBundle/Common/Macro/money.html.twig

And Variable "applied_promotions" does not exist. Differences : https://github.com/Sylius/Sylius/blob/v1.13.1/src/Sylius/Bundle/ShopBundle/Resources/views/Product/Box/_content.html.twig#L23 https://github.com/SyliusCrafts/BootstrapTheme/blob/v1.1.0/templates/bundles/SyliusShopBundle/Product/Box/_content.html.twig#L23

oallain commented 3 weeks ago

Thanks for your feedback.

Can you suggest a fix in pull request? Otherwise, I try to fix it as soon as possible.