SyliusCrafts / BootstrapTheme

Sylius Bootstrap theme with build process based on Webpack Encore
94 stars 56 forks source link

Add docker and test application for Bootstrap Theme #82

Closed pocky closed 3 years ago

pocky commented 3 years ago
Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets #50 #59 #60
License MIT

Like any plugin, this PR add a test application for BootstrapTheme. This application should be used to perform tests and/or be sure all templates works as expected.

Todolist:

4c0n commented 3 years ago

Personally I think it's a lot of extra files that you now need to maintain and update, whilst you could just use Sylius-Standard inside the container, but it's up to you.

pocky commented 3 years ago

@4c0n

Personally I think it's a lot of extra files that you now need to maintain and update, whilst you could just use Sylius-Standard inside the container, but it's up to you.

I understand your point but the test application works like any plugin and it's possible to test theme with or without Docker.

I want to open a PR for this subject in sylius/sylius-standard, probably with custom recipes.