Make compatible with SyliusThemeBundle 2.x (and so Sylius 1.9)

SyliusCrafts / BootstrapTheme

Sylius Bootstrap theme with build process based on Webpack Encore

94 stars 56 forks source link

Make compatible with SyliusThemeBundle 2.x (and so Sylius 1.9) #86

Closed maxperei closed 1 year ago

maxperei commented 3 years ago

Q	A
Branch?	master
Bug fix?	no
New feature?	no
BC breaks?	no
Deprecations?	yes
Related tickets	fixes #85
License	MIT

can you review @oallain plz :pray:

maxperei commented 3 years ago

to answer your previous question @oallain, i don't think so, because the only one assets/ folder — in this case — isn't related to any bundle and can be placed anywhere you want depending on the path mentioned in webpack.config.js:6 so according to me there ain't no need to change something here as long as manifest.json is properly configured...

maxperei commented 3 years ago

so @oallain, let me apologize because assets/ directory needed to be renamed as well to prevent public/_themes to be vanished during assets installation command

maxperei commented 1 year ago

no plan to make this works on the future