SyliusCrafts / BootstrapTheme

Sylius Bootstrap theme with build process based on Webpack Encore
94 stars 56 forks source link

Revert: Fix missing original price macro #92

Closed pocky closed 3 years ago

pocky commented 3 years ago

Hello,

https://github.com/SyliusCrafts/BootstrapTheme/pull/89 from @maxperei) was reverted because of this error Unknown "sylius_calculate_original_price" filter. Did you mean "sylius_caculate_price" ?

maxperei commented 3 years ago

hi @pocky, caculate are u sure ? you can revert if you want but before just make sure sylius > 1.8 because this filter exists since then cf. https://github.com/Sylius/Sylius/blob/d063b28b1c7f21da8968c1a881d7977964e68a29/src/Sylius/Bundle/CoreBundle/Twig/PriceExtension.php#L33

pocky commented 3 years ago

Hello @maxperei

Current application works only on 1.7, that's why we had this error. I will merge again your PR after #82