Open 50Wliu opened 4 years ago
Excellent, I was wondering where I could dump my progress notes so far lol and that list in the first post is very handy, thank you
Unless otherwise noted, these (as well as some other general UI stuff not listed) are done in the branch currently named UI-improvement (feeling an itch to rename that):
alt="GitHub icon"
yet--also, see long addition below<a>
) are now boldlg
instead of md
, partly because of new browse button and partly because there was some horizontal scrolling even without the browse buttonI've seen a few different things for alt text for headshots on pages like our About page. Based on what I've read, I gather that the following two methods are generally acceptable for profile pics on team pages:
alt=""
because they don't add additional information, assuming the pictures are just your average headshots (source; search "for example, profile"--it's a little more than halfway down the page)For now, since it's minor compared to other stuff, I've added some alt text for the anonymous and hamster images and left alt=""
for those of us who did add personal images.
Re: headshots, alt=""
seems like a loophole, while a description seems a little overboard. What if we just used the name of the person as the alt?
I feel the same way.
Since our headshots are followed directly by our names, using the name alone would be duplicating information with no additional value. Maybe we can just do alt="Headshot of name"
Maybe we can just do
alt="Headshot of name"
:+1:
Think I just got everything in the first post done!
Throwing everything in here for now so we can keep track of it. These work items are generated primarily from Lighthouse.
AA contrast requires a 4.5:1 ratio.
General
btn-primary
andbtn-success
buttons fail AA contrast: 3.98; 3.13Navbar
Landing
About
alt
descriptionsUpload
@mengsarah would you mind adding in the stuff you're working on?