search

SyllabiShare / syllabi-share

A app to help students share syllabi to assist in the college course selection process
GNU General Public License v3.0
9 stars 3 forks source link

Enable Bootstrap theming #82

Open 50Wliu opened 4 years ago

50Wliu commented 4 years ago

Uses django-sass-processor. To do this, I had to commit all the Bootstrap SCSS/JS files to this repo, which is a little unfortunate but I don't think there was any other way other than resorting to npm, which I do not want to do.

🚨 The documentation says that we need to install https://elements.heroku.com/buildpacks/drpancake/heroku-buildpack-django-sass for Heroku (:eyes: @verndrade). It works locally but I have no clue how badly things will break once we tie it in to S3 and Heroku. If you could deploy this to staging or somewhere before merging so we can make sure it works, that would be cool.

@mengsarah theming docs are at https://getbootstrap.com/docs/4.5/getting-started/theming/#variable-defaults. Sass has a guide as well as comprehensive documentation. I tried changing $success to black in style.scss, and it worked.

50Wliu commented 4 years ago

Oh, and the settings.py workaround for local dev:

# STATIC_URL = 'https://%s/%s/' % (AWS_S3_CUSTOM_DOMAIN, AWS_LOCATION)
# STATICFILES_STORAGE  = 'sass_processor.storage.SassS3Boto3Storage'
# DEFAULT_FILE_STORAGE = 'sass_processor.storage.SassS3Boto3Storage'
STATIC_URL = "/static/"