search

SyllabiShare / syllabi-share

A app to help students share syllabi to assist in the college course selection process
GNU General Public License v3.0
9 stars 3 forks source link

Leaderboard update #84

Closed verndrade closed 4 years ago

verndrade commented 4 years ago

Adds opt-out and makes leaderboard visible again

TODO: Fix UI (make position not fixed), Filter hidden syllabi?

50Wliu commented 4 years ago

self.userprofile_set.annotate(submissions=Count('user__submission', filter=Q(user__submission__hidden=False))).filter(submissions__gt=0).order_by('-submissions')[:5]

mengsarah commented 4 years ago

This is excellent, love the new styling. Only thing I would change is adding a bit more margin when the leaderboard moves below the courses.

I was going to say that I just changed that but oops, for about five minutes I forgot that pull requests and branches are two different things. It's tiny enough I feel like I shouldn't open an entirely new PR though haha.

I went into index.html and added the mb-3 class to the div that holds <h4>There {{num|pluralize:"is,are"}} {{num}} syllab{{num|pluralize:"us,i"}} for the {{school}}!</h4>. Adds a bit of extra space to the bottom on large enough screens, too, but I think it still looks okay.