search

Syllo / nvtop

GPU & Accelerator process monitoring for AMD, Apple, Huawei, Intel, NVIDIA and Qualcomm
Other
8.04k stars 291 forks source link

panfrost: replace debugfs profiling knob with sysfs #283

Open larunbe opened 6 months ago

larunbe commented 6 months ago

Kernel commit b12f3ea7c188 ("drm/panfrost: Replace fdinfo's profiling debugfs knob with sysfs") did away with the debugfs knob that lets profilers enable the hardware support for job accounting and fdinfo numbers. It was replaced with a similar interface, but this time around through sysfs.

Reflect this change in nvtop.

warpme commented 2 months ago

@larunbe thx for this fix! It works well for me on 6.10 mainline on g52 (e.g. rk3566) and g610 (rk3588). Unfortunatelly it not fixing non-working nvtop on g31 (e.g. h616). On g31 i'm getting:

Profiling state not available in Panfrost
No GPU to monitor.

Maybe you have idea where issue might be? btw: nvtop is working well for me on 6.9 with g31 - so issue starts by 6.9->6.10 kernel change

Syllo commented 2 months ago

Hi, Thanks for the patch. If I understand correctly this patch will make nvtop non working on kernels < 6.10 since it's the old interface or has your patch been back-ported to earlier kernel versions?

larunbe commented 2 weeks ago

Hi, Thanks for the patch. If I understand correctly this patch will make nvtop non working on kernels < 6.10 since it's the old interface or has your patch been back-ported to earlier kernel versions?

Yeah, that's right, 6.10 kernel release has the change that replaces the debugfs interface with sysfs.