search

SylvainTI / ostinato

Automatically exported from code.google.com/p/ostinato
GNU General Public License v3.0
0 stars 0 forks source link

uninstall script wants to remove bin directory! #100

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hey :-) I found that uninstall script wants to remove whole bin/ directory not 
only the files it installed, which is an obvious error :-)

sudo make uninstall
cd extra/ && make -f Makefile uninstall
cd qhexedit2/ && make -f Makefile uninstall
cd rpc/ && make -f Makefile.pbrpc uninstall
cd common/ && make -f Makefile.ostproto uninstall
cd server/ && make -f Makefile.drone uninstall
rm -f "/usr/local/bin/drone"
rmdir /usr/local//bin/
rmdir: /usr/local//bin/: Directory not empty
*** [uninstall_target] Error code 1 (ignored)
cd client/ && make -f Makefile.ostinato uninstall
rm -f "/usr/local/bin/ostinato"
rmdir /usr/local//bin/
rmdir: /usr/local//bin/: Directory not empty
*** [uninstall_target] Error code 1 (ignored)

Original issue reported on code.google.com by tomek.ce...@gmail.com on 9 Feb 2013 at 9:08

GoogleCodeExporter commented 9 years ago 
This is triggered from the following in the Makefile -

uninstall_target:  FORCE
    -$(DEL_FILE) "$(INSTALL_ROOT)/usr/bin/$(QMAKE_TARGET)"
    -$(DEL_DIR) $(INSTALL_ROOT)/usr/bin/ 

The Makefile is generated by qmake. One reason why qmake does this is, and I'm 
just speculating here, is to remove the install directory if it created it in 
the first place during "make install"; for standard install directory (or even 
non standard install directories which are not empty after deleting the target 
binaries), the DEL_DIR (rmdir) will fail with error "directory not empty", so 
it shouldn't cause any problems.

Since no harm is being done by this and since its essentially a qmake problem, 
we'll ignore it. Thanks for reporting it though!

Original comment by pstav...@gmail.com on 10 Feb 2013 at 4:58