search

SylvainTI / ostinato

Automatically exported from code.google.com/p/ostinato
GNU General Public License v3.0
0 stars 0 forks source link

HTTP \r #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Define TCP as transport protocol
2. Use L5 Text content
3. Set 80 - HTTP as applicaton protocol
4. Enter in the text field e.g. :
GET / HTTP/1.1
Host: www.onet.pl

What is the expected output? What do you see instead?
Wireshark does not decode created packet correctly - it does not recongnize
headers. 
There is no way to provide \r in the text field.
\n is done automatically by putting headers in different lines.
^M character did not help.

What version and revision of the product are you using (available in the
About dialog)? On what operating system?
Windows XP.

Please provide any additional information below.

Original issue reported on code.google.com by Michal.M...@gmail.com on 11 Oct 2010 at 7:27

GoogleCodeExporter commented 9 years ago 
Michal,

Can you send me the wireshark capture of the packet that it could not decode 
correctly?

Regarding entering a \r (CR), a quick glance through the Qt documentation 
doesn't reveal a solution. I'll get back to you if I find something.

Regards,
Srivats

Original comment by pstav...@gmail.com on 12 Oct 2010 at 1:14

GoogleCodeExporter commented 9 years ago 
Hello,

Pls check the attachments.

Sorry for this loooong delay in my answer.

Br,
Michal

Original comment by Michal.M...@gmail.com on 2 Nov 2010 at 10:25

Attachments:

GoogleCodeExporter commented 9 years ago 
Michal,

Regarding the incorrect decoding, I posted a query on the Wireshark mailing 
list and got some pointers - see 
http://www.wireshark.org/lists/wireshark-users/201011/msg00015.html

Regarding the end of line - I plan to extend the Text Protocol to let the user 
specify the desired line ending i.e. one of - CR, LF or CRLF. 

Let me know if you think something more is required.

Regards,
Srivats

Original comment by pstav...@gmail.com on 3 Nov 2010 at 5:10

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision 0836d810a4.

Original comment by pstav...@gmail.com on 4 Nov 2010 at 5:36

GoogleCodeExporter commented 9 years ago 
I do not really now. But I suppose most of protocols follow the schema that is 
used for HTTP that each header in HTTP request is terminated with CRLF.
E.g. RTSP would also need CRLF.

Original comment by Michal.M...@gmail.com on 4 Nov 2010 at 6:08

GoogleCodeExporter commented 9 years ago 
@michal: I think you are right - CRLF will probably be the most common 
requirement - but for flexibility (and maybe for error case testing!), I have 
implemented an option so that user can select either CR, LF or CRLF. If someone 
at a later date feels something more is required, we'll take that up then.

Thanks for raising the issue and helping me fix it!

Original comment by pstav...@gmail.com on 4 Nov 2010 at 6:21