search

SylvainTI / phpliteadmin

Automatically exported from code.google.com/p/phpliteadmin
0 stars 0 forks source link

row with all null values is collapsed #223

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. execute this statment

    SELECT 'aaa', 'bbb'
    UNION ALL
    SELECT null, null

What is the expected output? 
  two rows

What do you see instead?
  one normal row and other collapsed row (practicaly not visible)

What version of the product are you using? 
v1.9.4.1

On what operating system/browser?
linux - windows / firefox 22.0 - IE 8

Thanks for your great software !!!!

Original issue reported on code.google.com by l...@vfound.com.ar on 8 Aug 2013 at 9:44

GoogleCodeExporter commented 9 years ago 
Thanks for your report. I could reproduce it. I guess in fact we have two 
problems here:
1. a row should always have at least the height of a character
2. the cells should not be empty, but they should display NULL (in italics) to 
indicate this cell is NULL and not empty or something

Because at the moment if you do this:
SELECT NULL, ''
You cannot make a difference between the value of the first and second column.
Note that this works correctly if you browse a table. Seems to be another 
problem with redundant code here :-(

Original comment by crazy4ch...@gmail.com on 9 Aug 2013 at 10:22

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision r426.

Original comment by crazy4ch...@gmail.com on 24 Dec 2013 at 12:47

GoogleCodeExporter commented 9 years ago 
I just fixed this issue in svn. Now empty strings echo   to make sure the row 
height is not zero. And NULL gets displayed as NULL (in italics) now also in 
the sql tab.
We have more or less the same code 3 times here:
- action=table_sql
- view=sql
- action=row_view
share a big bunch of code. This issue was only done in case of action=row_view, 
I now also did it in the other two cases. We should really reduce redundant 
code here. I will open another issue for this particular case.

Original comment by crazy4ch...@gmail.com on 24 Dec 2013 at 12:51