search

SylvainTI / warrick

Automatically exported from code.google.com/p/warrick
0 stars 0 forks source link

New code mod. #22

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
check also these lines, needs to fixed

2025
2121
2157
2940

my line looks now so,

if($_[0] =~ m/\.jpg/i || $_[0] =~ m/\.jpeg/i || $_[0] =~ m/\.png/i || $_[0] =~ 
m/\.gif/i || $_[0] =~ m/\.doc/i || $_[0] =~ m/\.tiff/i || $_[0] =~ m/\.bmp/i || 
$_[0] =~ m/\.pdf/i)

small question, im not very familier with perl,

wouldnt it better if you putt all these formats in a global array on the top of 
the script

$blacklist = array("jpg", "tiff" .....) and foreach it against the filename, so 
its clearer and easier to fix, instead having it on 4 lines and check whats 
wrong. :)

Original issue reported on code.google.com by jbrunell...@gmail.com on 7 Dec 2012 at 3:29

GoogleCodeExporter commented 9 years ago

Original comment by jbrunell...@gmail.com on 28 May 2013 at 6:04