search

SylvainTI / wwwsqldesigner

Automatically exported from code.google.com/p/wwwsqldesigner
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Drag n Drop multiple table at the same time #32

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. It is not possible to drag n drop more than one table at the time (when
moving them around)

What is the expected output? What do you see instead?
It would very practical to be able to do so! :)

What version of the product are you using? On what operating system?
r45

Original issue reported on code.google.com by kevin.sa...@gmail.com on 9 Jul 2009 at 12:04

GoogleCodeExporter commented 9 years ago 
Good idea. However, when multiple tables are selected (with shift/ctrl), some 
table
operations would become disabled (editing, keys).

Original comment by ondrej.zara on 9 Jul 2009 at 2:08

GoogleCodeExporter commented 9 years ago 
Attached is a patch with implementation.

I only implemented multiple selection with shift, not with ctrl -- should ctrl 
be
used too?

This patch does not implement a rubberband selector, this would be a separate
issue and I will open it once this gets through.

Note: If/when the visual snap patch gets integrated, this one will have to be
updated since it touches code around where snap happens.

Original comment by ober.14@osu.edu on 12 Nov 2009 at 4:03

Attachments:

GoogleCodeExporter commented 9 years ago 
Separate question, but it came up while working on this one:

It would be useful to have a version of Array.map, say Array.mapMethod,
that does not pass _this as the first argument, instead passing this[i].
Say when I have an array of SQL.Tables and want to convert it to an array
of titles, I'd simply do tables.mapMethod(SQL.Table.prototype.getTitle)

Does it make sense, or does existing Array.map() accomplish that somehow??
If it's a valid proposal, then I'd submit it as an issue to oz, together with an
implementation.

Original comment by ober.14@osu.edu on 12 Nov 2009 at 4:07

GoogleCodeExporter commented 9 years ago 
Please provide a patch against current revision (r62), I will gladly accept it.

As for the Array.mapMethod: all Array.prototype.* methods comply with JS 1.6
specification (https://developer.mozilla.org/en/New_in_JavaScript_1.6) and I do 
not
want to add any other, non-standardized method. Modification of builtin 
prototypes is
a problematic stuff and I would like to evade it if possible.

Original comment by ondrej.zara on 12 Nov 2009 at 6:39

GoogleCodeExporter commented 9 years ago 
Updated patch against r62.

Original comment by ober.14@osu.edu on 12 Nov 2009 at 7:58

Attachments:

GoogleCodeExporter commented 9 years ago 
Thanks, commited in r63.

Original comment by ondrej.zara on 14 Nov 2009 at 2:55

GoogleCodeExporter commented 9 years ago 
it works great! Thanks a lot k...@! ;)

Original comment by kevin.sa...@gmail.com on 25 Nov 2009 at 8:46