Open mithro opened 5 years ago
@mkurc-ant I probably won't get to this until tomorrow, if you get a chance PTAL and fix the branch.
@mithro I can fix that. But why would we want to use this code? The solution implemented here was not accepted by the Yosys devs. The upstream Yosys already has support for attributes on parameters - they are mocked by dummy wires.
@mithro Now I see. We have merged this implementation of attributes on parameters into our master+wip but it was not accepted and not merged upstream.
If we want to merge with upstream we need to remove this code as it will cause conflict.
@mithro I fixed the branch by reverting the merge of https://github.com/YosysHQ/yosys/pull/1109. It builds but the conflict with upstream master remains.
When trying to rebase onto
upstream/master
and create theattributes-on-parameters
branch I seem to have broken things;Don't have time to look at things now, but probably an easy fix