SymbioticLab / FedScale

FedScale is a scalable and extensible open-source federated learning (FL) platform.
https://fedscale.ai
Apache License 2.0
388 stars 119 forks source link

Redis Support for FedScale #170

Open xuyehe opened 2 years ago

xuyehe commented 2 years ago

Why are these changes needed?

To integrate Redis into aggregator for saving aggregation data.

Related issue number

N/A

Checks

Note:

  1. All tests are run on cpu.
  2. Met with the following KeyError bug on the same line in Femnist once with Redis, and also once without Redis (i.e. original code). Sample error output:
    File "/users/xuyehe/FedScale-rd/fedscale/core/aggregation/aggregator.py", line 386, in client_completion_handler
    duration=self.virtual_client_clock[results['clientId']]['computation'] +
    KeyError: 665
fanlai0990 commented 2 years ago

Thanks a lot for your contribution! Let's try to run an e2e evaluation to validate the learning curve and Redis overhead first.

fanlai0990 commented 2 years ago

Thanks for your contribution. Can you please

We really appreciate your help.