search

SymbioticLab / FedScale

FedScale is a scalable and extensible open-source federated learning (FL) platform.
https://fedscale.ai
Apache License 2.0
383 stars 121 forks source link

[Example/Notebook] Jupyer Notebook Server and Client Example Contain Old Code Leads Error #177

Open mtang724 opened 1 year ago

mtang724 commented 1 year ago

What happened + What you expected to happen

In FedScale/examples/notebook, the server and client contain old code "from fedscale.core.logger.execution import args" which suppose to be in new form "import fedscale.core.config_parser as parser" -> args = parser.args

Versions / Dependencies

FedScale 0.5, pip install -e .

Reproduction script

It happened when I tried to run the example code in jupyter notebook after installation. So it would be great to fix it to not to confuse new users.

Issue Severity

Low: It annoys or frustrates me.

fanlai0990 commented 1 year ago

@IKACE Can you please fix this due to the last commit? #175 Thanks!

IKACE commented 1 year ago

Thank you for catching this bug! I've submitted a fix PR to the master branch.