SymbolicML / DynamicExpressions.jl

Ridiculously fast symbolic expressions
https://symbolicml.org/DynamicExpressions.jl/dev
Apache License 2.0
92 stars 12 forks source link

Fix printing of complex numbers #19

Closed MilesCranmer closed 1 year ago

MilesCranmer commented 1 year ago

Because complex numbers print with either a + or - operator, the expression printing can have expressions $x c$, for $c$ a constant, which actually gets printed like $x 1.0 - 2.0im$, which looks like $x * c - b$ for two constants.

This PR implements a fix - any number which is neither a real number nor a vector will be printed inside an additional parentheses.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 4462840124


Totals Coverage Status
Change from base Build 4443081921: 0.3%
Covered Lines: 988
Relevant Lines: 1086

💛 - Coveralls