SymbolicML / DynamicQuantities.jl

Efficient and type-stable physical quantities in Julia
https://symbolicml.org/DynamicQuantities.jl/dev/
Apache License 2.0
120 stars 15 forks source link

fix tests on 1.11 #133

Closed KristofferC closed 2 months ago

KristofferC commented 2 months ago

A refactoring in the round function caused this method definition to be ambiguous.

github-actions[bot] commented 2 months ago

Benchmark Results

main ee7afbd726ca1a... main/ee7afbd726ca1a...
Quantity/creation/Quantity(x) 2.79 ± 0 ns 2.79 ± 0 ns 1
Quantity/creation/Quantity(x, length=y) 3.41 ± 0.01 ns 3.41 ± 0.01 ns 1
Quantity/with_numbers/*real 3.11 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/with_numbers/^int 8.05 ± 1.9 ns 8.05 ± 1.9 ns 1
Quantity/with_numbers/^int * real 8.37 ± 1.9 ns 8.37 ± 1.9 ns 1
Quantity/with_quantity/+y 4.04 ± 0.001 ns 4.04 ± 0.001 ns 1
Quantity/with_quantity//y 3.11 ± 0.001 ns 3.11 ± 0.001 ns 1
Quantity/with_self/dimension 3.1 ± 0.01 ns 3.1 ± 0.01 ns 1
Quantity/with_self/inv 3.11 ± 0.001 ns 3.11 ± 0.001 ns 1
Quantity/with_self/ustrip 2.79 ± 0.01 ns 3.71 ± 0.01 ns 0.754
QuantityArray/broadcasting/multi_array_of_quantities 0.143 ± 0.00067 ms 0.143 ± 0.00073 ms 1
QuantityArray/broadcasting/multi_normal_array 0.0529 ± 0.00028 ms 0.0529 ± 0.00029 ms 1
QuantityArray/broadcasting/multi_quantity_array 0.158 ± 0.00094 ms 0.158 ± 0.00083 ms 1
QuantityArray/broadcasting/x^2_array_of_quantities 24.5 ± 2.3 μs 25.4 ± 2.6 μs 0.966
QuantityArray/broadcasting/x^2_normal_array 5.29 ± 0.77 μs 5.79 ± 0.46 μs 0.913
QuantityArray/broadcasting/x^2_quantity_array 7.04 ± 0.31 μs 6.99 ± 0.28 μs 1.01
QuantityArray/broadcasting/x^4_array_of_quantities 0.0786 ± 0.00057 ms 0.0788 ± 0.00053 ms 0.997
QuantityArray/broadcasting/x^4_normal_array 0.0498 ± 0.00015 ms 0.0498 ± 0.00016 ms 1
QuantityArray/broadcasting/x^4_quantity_array 0.05 ± 0.00017 ms 0.05 ± 0.0002 ms 0.999
time_to_load 0.131 ± 0.0022 s 0.129 ± 0.00081 s 1.02

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

MilesCranmer commented 2 months ago

Thanks!