search

SymbolicML / DynamicQuantities.jl

Efficient and type-stable physical quantities in Julia
https://symbolicml.org/DynamicQuantities.jl/dev/
Apache License 2.0
132 stars 17 forks source link

Fix broadcast stack overflow #38

Closed gaurav-arya closed 1 year ago

gaurav-arya commented 1 year ago

Presumably on 1.10 the broadcast/convert logic is smart enough to not call that convert method in the first place. Mirrors logic in e.g. https://github.com/JuliaLang/julia/blob/b3741c01f2e2d4956be3ba41858c4065c6fbc7e8/base/array.jl#L663

MilesCranmer commented 1 year ago

Good catch!! Thanks