sweep-ai[bot] commented 10 months ago

PR Feedback: 👎

Description

This pull request adds a new struct called NoDims and updates the dimension function in the DynamicQuantities module. It also includes a new test file nodims.jl to test the changes.

Summary

Added NoDims struct to indicate that something is not a quantity.
Updated dimension function to return NoDims() for non-quantity objects.
Added tests for NoDims and dimension functions.
Added tests for math operations with quantities.

Fixes #88.

🎉 Latest improvements to Sweep:

Sweep now uses the rope library to refactor Python! Check out Large Language Models are Bad at Refactoring Code. To have Sweep refactor your code, try sweep: Refactor <your_file>.py!
Sweep finds and fixes bugs in your code by writing unit tests! Check out Having GPT-4 Iterate on Unit Tests like a Human.

💡 To get Sweep to edit this pull request, you can:

Comment below, and Sweep can edit the entire PR
Comment on a file, Sweep will only modify the commented file
Edit the original issue to get Sweep to recreate the PR from scratch

sweep-ai[bot] commented 10 months ago

Sandbox Executions

[X] Ran sandbox for src/types.jl. ✓

Sandbox logs for

trunk fmt src/types.jl || exit 0 1/2 ✓
Found no applicable linters for the requested path
trunk check --fix --print-failures src/types.jl 2/2 ✓
Checked 1 file
✔ No issues

[X] Ran sandbox for src/math.jl. ✓

Sandbox logs for

trunk fmt src/math.jl || exit 0 1/2 ✓
Found no applicable linters for the requested path
trunk check --fix --print-failures src/math.jl 2/2 ✓
Checked 1 file
✔ No issues

[X] Ran sandbox for test/nodims.jl. ✓

Sandbox logs for

trunk fmt test/nodims.jl || exit 0 1/2 ✓
Found no applicable linters for the requested path
trunk check --fix --print-failures test/nodims.jl 2/2 ✓
Checked 1 file
✔ No issues

sweep-ai[bot] commented 10 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All docstrings and comments should be up to date.
[ ] Apply: All new logic should have corresponding unit tests.

sweep-ai[bot] commented 10 months ago

The command: Run julia-actions/cache@v1 yielded the following error: `##[error]The operation was canceled.

[group]Run julia-actions/cache@v1

with: cache-name: julia-cache cache-artifacts: true cache-packages: true cache-registries: false cache-compiled: false cache-scratchspaces: true

[endgroup]

[group]Run [ "true" = "true" ] && A_PATH="~/.julia/artifacts"

[36;1m[ "true" = "true" ] && A_PATH="~/.julia/artifacts"[0m [36;1mecho "artifacts-path=$A_PATH" >> $GITHUB_OUTPUT[0m [36;1m[ "true" = "true" ] && P_PATH="~/.julia/packages"[0m [36;1mecho "packages-path=$P_PATH" >> $GITHUB_OUTPUT[0m [36;1m[ "false" = "true" ] && R_PATH="~/.julia/registries"[0m [36;1mecho "registries-path=$R_PATH" >> $GITHUB_OUTPUT[0m [36;1m[ "false" = "true" ] && PCC_PATH="~/.julia/compiled"[0m [36;1mecho "precompilation-cache-path=$PCC_PATH" >> $GITHUB_OUTPUT[0m [36;1m[ "true" = "true" ] && S_PATH="~/.julia/scratchspaces"[0m [36;1mecho "scratchspaces-path=$S_PATH" >> $GITHUB_OUTPUT[0m shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}

[endgroup]

[group]Run actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84

with: path: ~/.julia/artifacts ~/.julia/packages

~/.julia/scratchspaces key: Linux-julia-cache-f1875dc23e351cf4010140a366977343314e50b6c9454a6b730f23f6d56787f9 restore-keys: Linux-julia-cache-

enableCrossOsArchive: false fail-on-cache-miss: false lookup-only: false

[endgroup]

[error]The operation was canceled.

[group]Run julia --project=docs/ -e '

[36;1mjulia --project=docs/ -e '[0m [36;1m using Pkg[0m [36;1m Pkg.develop(PackageSpec(path=pwd()))[0m [36;1m Pkg.instantiate()'[0m shell: /usr/bin/bash -e {0}

[endgroup]

Installing known registries into ~/.julia Resolving package versions... Installed Tricks ────────────────── v0.1.8 Installed RegistryInstances ─────── v0.1.0 Installed Parsers ───────────────── v2.8.0 Installed MarkdownAST ───────────── v0.1.2 Installed JSON ──────────────────── v0.21.4 Installed Preferences ───────────── v1.4.1 Installed Compat ────────────────── v4.10.0 Installed AbstractTrees ─────────── v0.4.4 Installed PackageExtensionCompat ── v1.0.2 Installed PrecompileTools ───────── v1.2.0 Installed ANSIColoredPrinters ───── v0.0.1 Installed LazilyInitializedFields ─ v1.2.2 Installed DocStringExtensions ───── v0.9.3 Installed Documenter ────────────── v1.1.2 Installed IOCapture ─────────────── v0.2.3 Updating ~/work/DynamicQuantities.jl/DynamicQuantities.jl/docs/Project.toml [e30172f5] + Documenter v1.1.2 [06fc5a27] + DynamicQuantities v0.9.0 ~/work/DynamicQuantities.jl/DynamicQuantities.jl Updating ~/work/DynamicQuantities.jl/DynamicQuantities.jl/docs/Manifest.toml [a4c015fc] + ANSIColoredPrinters v0.0.1 [1520ce14] + AbstractTrees v0.4.4 [34da2185] + Compat v4.10.0 [ffbed154] + DocStringExtensions v0.9.3 [e30172f5] + Documenter v1.1.2 [06fc5a27] + DynamicQuantities v0.9.0 ~/work/DynamicQuantities.jl/DynamicQuantities.jl [b5f81e59] + IOCapture v0.2.3 [682c06a0] + JSON v0.21.4 [0e77f7df] + LazilyInitializedFields v1.2.2 [d0879d2d] + MarkdownAST v0.1.2 [65ce6f38] + PackageExtensionCompat v1.0.2 [69de0a69] + Parsers v2.8.0 [aea7be01] + PrecompileTools v1.2.0 [21216c6a] + Preferences v1.4.1 [2792f1a3] + RegistryInstances v0.1.0 [410a4b4d] + Tricks v0.1.8 [0dad84c5] + ArgTools v1.1.1 [56f22d72] + Artifacts [2a0f44e3] + Base64 [ade2ca70] + Dates [f43a241f] + Downloads v1.6.0 [7b1f6079] + FileWatching [b77e0a4c] + InteractiveUtils [b27032c2] + LibCURL v0.6.4 [76f85450] + LibGit2 [8f399da3] + Libdl [56ddb016] + Logging [d6f4376e] + Markdown [a63ad114] + Mmap [ca575930] + NetworkOptions v1.2.0 [44cfe95a] + Pkg v1.9.2 [de0858da] + Printf [3fa0cd96] + REPL [9a3f8284] + Random [ea8e919c] + SHA v0.7.0 [9e88b42a] + Serialization [6462fe0b] + Sockets [fa267f1f] + TOML v1.0.3 [a4e569a6] + Tar v1.10.0 [8dfed614] + Test [cf7118a7] + UUIDs [4ec0a83e] + Unicode [deac9b47] + LibCURL_jll v8.4.0+0 [29816b5a] + LibSSH2_jll v1.11.0+1 [c8ffd9c3] + MbedTLS_jll v2.28.2+0 [14a3606d] + MozillaCACerts_jll v2022.10.11 [83775a58] + Zlib_jll v1.2.13+0 [8e850ede] + nghttp2_jll v1.52.0+1 [3f19e933] + p7zip_jll v17.4.0+0 Precompiling project... [32m ✓ [39m[90mPackageExtensionCompat[39m [32m ✓ [39m[90mLazilyInitializedFields[39m [32m ✓ [39m[90mTricks[39m [32m ✓ [39m[90mCompat[39m [32m ✓ [39m[90mANSIColoredPrinters[39m [32m ✓ [39m[90mIOCapture[39m [32m ✓ [39m[90mPreferences[39m [32m ✓ [39m[90mDocStringExtensions[39m [32m ✓ [39m[90mRegistryInstances[39m [32m ✓ [39m[90mAbstractTrees[39m [32m ✓ [39m[90mCompat → CompatLinearAlgebraExt[39m [32m ✓ [39m[90mPrecompileTools[39m [32m ✓ [39m[90mMarkdownAST[39m [91m ✗ [39mDynamicQuantities [91m ✗ [39m[90mDynamicQuantities → DynamicQuantitiesLinearAlgebraExt[39m

[error]The operation was canceled.`

Here are the logs:

##[group]Run [ "true" = "true" ] && A_PATH="~/.julia/artifacts"
[36;1m[ "true" = "true" ] && A_PATH="~/.julia/artifacts"[0m
[36;1mecho "artifacts-path=$A_PATH" >> $GITHUB_OUTPUT[0m
[36;1m[ "true" = "true" ] && P_PATH="~/.julia/packages"[0m
[36;1mecho "packages-path=$P_PATH" >> $GITHUB_OUTPUT[0m
[36;1m[ "false" = "true" ] && R_PATH="~/.julia/registries"[0m
[36;1mecho "registries-path=$R_PATH" >> $GITHUB_OUTPUT[0m
[36;1m[ "false" = "true" ] && PCC_PATH="~/.julia/compiled"[0m
[36;1mecho "precompilation-cache-path=$PCC_PATH" >> $GITHUB_OUTPUT[0m
[36;1m[ "true" = "true" ] && S_PATH="~/.julia/scratchspaces"[0m
[36;1mecho "scratchspaces-path=$S_PATH" >> $GITHUB_OUTPUT[0m
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
##[endgroup]
##[group]Run actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84
with:
path: ~/.julia/artifacts
~/.julia/packages

~/.julia/scratchspaces
key: Linux-julia-cache-f1875dc23e351cf4010140a366977343314e50b6c9454a6b730f23f6d56787f9
restore-keys: Linux-julia-cache-

enableCrossOsArchive: false
fail-on-cache-miss: false
lookup-only: false
##[endgroup]
Received 20971520 of 96481304 (21.7%), 20.0 MBs/sec

sweep-ai[bot] commented 10 months ago

🚀 Wrote Changes

Done.

SymbolicML / DynamicQuantities.jl

Add NoDims type and update dimension function #89

PR Feedback: 👎

Description

Summary

🎉 Latest improvements to Sweep:

💡 To get Sweep to edit this pull request, you can:

Sandbox Executions

Apply Sweep Rules to your PR?

[group]Run julia-actions/cache@v1

[endgroup]

[group]Run [ "true" = "true" ] && A_PATH="~/.julia/artifacts"

[endgroup]

[group]Run actions/cache@704facf57e6136b1bc63b828d79edcd491f0ee84

[endgroup]

[error]The operation was canceled.

[group]Run julia --project=docs/ -e '

[endgroup]

[error]The operation was canceled.`

🚀 Wrote Changes