Open gaurangkudale opened 1 year ago
Hi @gaurangkudale! Thanks for your patience. I noticed some issues:
[ ] currently, there is a conflict in the README.md. Can you resolve this?
[ ] for the README: the file gets very long now, I suggest putting the Docker comments in a separate file and linking it. Also, the section for the Docker gets buried under the "Building, Testing, Running" section, and some of the outputs should be hidden by default.
[ ] in the documentation I would prefer a command like this docker run --rm --name spf-docker -it spf:latest bash
[ ] please also add an example to illustrate the usage of this docker container
[ ] I tried the following but it seems that the jpf-core is not built:
yannic_noller@ECCLT2203805s-MacBook-Pro SPF % docker run --rm --name spf-docker -it spf:latest bash
root@19bee9c062bb:/app# ls
Dockerfile README.md build.gradle entrypoint.sh gradle gradlew gradlew.bat jpf-core jpf-symbc settings.gradle
root@19bee9c062bb:/app# cd jpf-symbc/
root@19bee9c062bb:/app/jpf-symbc# java -Xmx1024m -ea -jar ../jpf-core/build/RunJPF.jar ./src/examples/demo/NumericExample.jpf
Error: Unable to access jarfile ../jpf-core/build/RunJPF.jar
I will do more testing, after this is fixed. Thanks!
Hi @yannicnoller,
I have added the dockerfile https://github.com/SymbolicPathFinder/jpf-symbc/commit/5177e7c7fafe55917ebf8757d9ec447a1fa9b4d8 in this commit and also updated the README file https://github.com/SymbolicPathFinder/jpf-symbc/commit/7a2b65d3935d9de6849015073e9feec723972309 Please review and let me know if there are any suggestions.
Thank you