SymbolixAU / mapdeck

R interface to Deck.gl and Mapbox
https://symbolixau.github.io/mapdeck/articles/mapdeck.html
362 stars 40 forks source link

quarto tabset and mapdeck #376

Closed xtimbeau closed 10 months ago

xtimbeau commented 11 months ago

Describe the bug when using tabsets in quarto with mapdecks, the hidden tabset is not working. This appears with th edev version, not the CRAN one.

To Reproduce

---
title: "tabset and mapdeck"
format: html
---
library(mapdeck)
# you need a token for that to work

::: panel-tabset
## panel 1
this one is working, you can zoom the map
```{r}
mapdeck::mapdeck()

panel 2

This one is dead

mapdeck::mapdeck()

:::



**Expected behaviour**
hidden tabset mapdeck should function when made visible

**Versions**
It is working with mapdeck 0.3.4 not with 0.3.4.004
dcooley commented 11 months ago

I'm 99% sure this is the same issue as - https://github.com/SymbolixAU/mapdeck/issues/373

While waiting for the next deck.gl release, I've downgraded the bundled deck.gl to 8.9.11 so at least the multi-tab works.

(Although I can't test your code because it errors for me)

xtimbeau commented 11 months ago

ok, sounds clear. It is related to visibility. I’ll test it as soon as the next deck.gl is released

Le lun. 4 déc. 2023 à 22:12, Dave @.***> a écrit :

I'm 99% sure this is the same issue as - #373 https://github.com/SymbolixAU/mapdeck/issues/373

While waiting for the next deck.gl release, I've downgraded the bundled deck.gl to 8.9.11 so at least the multi-tab works.

(Although I can't test your code because it errors for me)

— Reply to this email directly, view it on GitHub https://github.com/SymbolixAU/mapdeck/issues/376#issuecomment-1839485020, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2KEN7Z3DRHMXWFJ3C553YHY4E3AVCNFSM6AAAAABAGK5P2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGQ4DKMBSGA . You are receiving this because you authored the thread.Message ID: @.***>

dcooley commented 11 months ago

If you re-install the latest mapdeck github version it should work again as expected (I've downgraded it to the version before #373 broke).

xtimbeau commented 11 months ago

I’ll try tomorrow

Le lun. 4 déc. 2023 à 22:45, Dave @.***> a écrit :

If you re-install the latest mapdeck github version it should work again as expected.

— Reply to this email directly, view it on GitHub https://github.com/SymbolixAU/mapdeck/issues/376#issuecomment-1839534151, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANA2KENOCVOP2LJUPODMEGTYHY77RAVCNFSM6AAAAABAGK5P2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGUZTIMJVGE . You are receiving this because you authored the thread.Message ID: @.***>

dcooley commented 11 months ago

given - https://github.com/SymbolixAU/mapdeck/issues/373#issuecomment-1846544648 - can you try this now using the latest 'master' branch?

xtimbeau commented 11 months ago

Hi, I have installed the latest from main and it seems to be working fine. I'll do further testing and keep you informed.

dcooley commented 10 months ago

Please reopen if issue persists