search

SymfonyCasts / reset-password-bundle

Need a killer reset password feature for your Symfony? Us too!
https://symfonycasts.com
MIT License
477 stars 68 forks source link

Requires default_uri to be defined #249

Closed akincer closed 2 years ago

akincer commented 2 years ago

This might confuse some folks that are getting localhost as the root of the generated URI due to url() in twig prepending localhost without having default_uri defined in routing.yaml.

weaverryan commented 2 years ago

I don't think we can require default_uri in this bundle, as it comes from another bundle. However, this is definitely an easy place to mess up, so it could definitely be mentioned in the README - like if you're getting localhost URLs on production, you should set this.

akincer commented 2 years ago

Right. Should have been more explicit - for production and a note in the README was exactly what I had in mind.

On Mon, Oct 31, 2022, 10:01 AM Ryan Weaver @.***> wrote:

I don't think we can require default_uri in this bundle, as it comes from another bundle. However, this is definitely an easy place to mess up, so it could definitely be mentioned in the README - like if you're getting localhost URLs on production, you should set this.

— Reply to this email directly, view it on GitHub https://github.com/SymfonyCasts/reset-password-bundle/issues/249#issuecomment-1297138578, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACKNL5HCOLKKYFSXM7RBHTWF7GMDANCNFSM6AAAAAARTDLSLQ . You are receiving this because you authored the thread.Message ID: @.***>

weaverryan commented 2 years ago

PR warmly welcomed for this :)

akincer commented 2 years ago

Created. If the wording needs changed just let me know.

bocharsky-bw commented 2 years ago

Just for reference: #250