search

SymfonyCasts / tailwind-bundle

Delightful Tailwind Support for Symfony + AssetMapper
https://symfony.com/bundles/TailwindBundle/current/index.html
MIT License
84 stars 20 forks source link

Allowing a custom config_file relative to the project #30

Closed barbieswimcrew closed 11 months ago

barbieswimcrew commented 1 year ago

This PR allows one to set a custom path to the tailwind.config.js

barbieswimcrew commented 1 year ago

@bocharsky-bw i resolved all issues the ci tool identified. is there anything else for me to do? 🙂

barbieswimcrew commented 1 year ago

Hey, thanks for sending this PR! I left some comments

Also, I see you make this config path configurable... but I wonder what use case is behind of this feature? IMO hardcoded Tailwind CSS config file in the root folder is kind of standard makes things simpler, no? I mean, could you describe your specific use case better, where are you keeping your config file and why not in the project root?

Hi @bocharsky-bw thanks for your reply. The ability to configure the path of the configuration file makes it possible to deliver the configuration in an encapsulated bundle. I have a Shopware6 project based on Symfony and have created a bundle for a custom theme. Each theme is a separate bundle, hence the requirement.

bocharsky-bw commented 11 months ago

Hey @barbieswimcrew ,

Sorry for the delay on this! It seems like this now has merge conflicts... sorry about it too! Could you fix them to move it forward?

barbieswimcrew commented 11 months ago

Hey @barbieswimcrew ,

Sorry for the delay on this! It seems like this now has merge conflicts... sorry about it too! Could you fix them to move it forward?

Hey @bocharsky-bw

no worries! Updated the pr... let me know if I can help in any way :-)