hindsight is 20/20 eh? #177 replaced psalm w/ phpstan WooHoo! But - I goofed... In reset-password, maker-bundle, etc... I:
added phpstan
generated a baseline
merged
created PR's to fix issues & remove baseline entries until the baseline was gone.
Here i did the opposite. added phpstan -> fixed the issues -> merged in 2.x. Leaving 1.x w/o static coverage (psalm is no longer used). This PR cherry picks the bare minimum to get phpstan into 1.x w/ a generated baseline. The issues suppressed in phpstan-baseline.neon have already been fixed in 2.x.
Going forward in 1.x - we won't fix any of the issues in the baseline (e.g. fix -> remove suppression) as this is already done (2.x). But - we won't add any new suppression's to the baseline in 1.x either. Otherwise I think, aside from doing duplicate work, we'd start to drift into merge hell... It's already hot enough here in Florida - let's not go any further south.
That said, if we need to fix a one off suppression here and there in 1.x - so be it...
hindsight is 20/20 eh? #177 replaced psalm w/ phpstan WooHoo! But - I goofed... In reset-password, maker-bundle, etc... I:
Here i did the opposite. added phpstan -> fixed the issues -> merged in 2.x. Leaving 1.x w/o static coverage (psalm is no longer used). This PR cherry picks the bare minimum to get phpstan into 1.x w/ a generated baseline. The issues suppressed in
phpstan-baseline.neonhave already been fixed in 2.x.Going forward in 1.x - we won't fix any of the issues in the baseline (e.g. fix -> remove suppression) as this is already done (2.x). But - we won't add any new suppression's to the baseline in 1.x either. Otherwise I think, aside from doing duplicate work, we'd start to drift into merge hell... It's already hot enough here in Florida - let's not go any further south.
That said, if we need to fix a one off suppression here and there in 1.x - so be it...