use new bundle strategy

SymfonyCasts / verify-email-bundle

Simple, stylish Email Verification for Symfony

https://symfonycasts.com

MIT License

403 stars 32 forks source link

use new bundle strategy #186

Closed jrushlow closed 4 months ago

jrushlow commented 5 months ago

~wip -~ see https://github.com/symfony/symfony-docs/pull/19793

[x] double check the structure against https://symfony.com/doc/current/bundles/best_practices.html && the PR mentioned above
[x] test locally
[x] test in linked app on linux
[ ] test in linked app on macos
[ ] test again...
[x] ~add test to ensure if lifetime is changed in userland - the new value is used in the helper... this may already be a thing~ - To be completed under #187

yceruto commented 5 months ago

About the directory structure, there is one more possible change that matches the modern skeleton: the translations/ directory can be moved to the root level too

jrushlow commented 5 months ago

About the directory structure, there is one more possible change that matches the modern skeleton: the translations/ directory can be moved to the root level too

@yceruto - I was just thinking about the best way to handle that. ~And I believe it'll be done outside of this PR.~ reset-password && verify-email have the exact same translations - to keep from adding too much noise to this PR - I need to mv and add any missing translations that exist in one bundle but not the other.

jrushlow commented 4 months ago

@yceruto - I'm wondering if we could / should add array "shape" annotation(s) to https://github.com/symfony/symfony/blob/65ccca07588b108246a2aa3f5c8214e045c376be/src/Symfony/Component/HttpKernel/Bundle/AbstractBundle.php#L38 for better DX

PHPStan Squawk:

Fixed by: https://github.com/SymfonyCasts/verify-email-bundle/pull/186/commits/089cec8d33e108a45bcccd9ad1ffd30fffc4c241