search

SymmetricDevs / Supersymmetry

Repository for the Supersymmetry Minecraft Modpack
GNU Lesser General Public License v3.0
217 stars 92 forks source link

Gregtech machines show as "unnamed.name" with no image in Xnet controllers #877

Closed ppebb closed 3 months ago

ppebb commented 6 months ago

Description of the Bug

Xnet controllers do not get the proper name of Gregtech machines connected to the network and do not have an image. image

Reproduction

  1. Place a Gregtech machine
  2. Connect it with an xnet connector
  3. Place a controller on the same network
  4. Open the controller and you should see something similar to the above screenshot.

Version

0.1.12.7

Relevant log output

No response

trainvoi commented 6 months ago

known problem, unfortunately it's on xnet side

chairclr commented 6 months ago

Here's the offending line: https://github.com/McJtyMods/XNet/blob/0ca5b08e451f4c9adce2ebafcb9767171a9ec67f/src/main/java/mcjty/xnet/modules/controller/client/GuiController.java#L601

Is it possible that Supersymmetry could use a fork of xnet with this fixed?

loxoDev commented 6 months ago

We do have a fork, @ISurrealI is "managing" it. Maybe they could take a look.

ppebb commented 5 months ago

Is this fork public? We were unable to find it on any associsted accounts or orgs. We'd like to go ahead and fix this at least for our own use even if we can't PR.

trainvoi commented 5 months ago

Is this fork public? We were unable to find it on any associsted accounts or orgs. We'd like to go ahead and fix this at least for our own use even if we can't PR.

https://www.curseforge.com/minecraft/mc-mods/ynet-an-xnet-fork here's the link and here's the repo https://github.com/CaliforniaDemise/XNet-1.12

MCTian-mi commented 3 months ago

fixed in either one of the PRs you can see above