search

SymmetricInfinity / push_package

A gem for creating Safari push notification push packages.
symmetricinfinity.com/push_package
MIT License
31 stars 14 forks source link

Support using a pem file in addition to a p12. #14

Closed jonhyman closed 8 years ago

jonhyman commented 8 years ago

We have some customers who have pem files for their certificates instead of their p12 files, it would be nice to support both.

jonhyman commented 8 years ago

Hm. It looks like adding Gemfile.lock might have caused Travis to fail? The specs all pass locally for me, I do not know about the CI setup.

adamvduke commented 8 years ago

Hi @jonhyman,

Thanks for taking time to add support for this. We leave the Gemfile.lock out of the repo intentionally based on this post http://yehudakatz.com/2010/12/16/clarifying-the-roles-of-the-gemspec-and-gemfile/. I think Travis will re-run if you remove that file from your commit and force push your branch.

jonhyman commented 8 years ago

Thanks for the context. I updated, looks like we're good now.

adamvduke commented 8 years ago

I pushed a new version, 0.5.0, to rubygems.

🍻

jonhyman commented 8 years ago

Thank you!