search

SymphoniaIO / web-musicxml-editor

Online notation editor with basic MusicXML support. Uses VexFlow for notation engraving.
MIT License
73 stars 8 forks source link

Measure does not extend after key/time signature addition #4

Open freetomik opened 7 years ago

freetomik commented 7 years ago

How to reproduce: Try to open e.g. Saltarello example, select first measure and set key signature to C#. Result: Measure does not extend and some notes are shifted into the next measure. Expected result: Measure width is extended properly to contain all the notes.

freetomik commented 7 years ago

Recommended solution: Add into object staveAttributes in parse.js item "width", which will represent stave(measure) width. When key/time signature is changed, alter that width accordingly - probably in editor.add.keySignature method. Then set that width to stave in editor.draw.measure by calling stave.setWidth(...);

jameschensmith commented 6 years ago

Hey @freetomik, I know it's been a while, but I did a quick fix to the issue. I've been really busy with work, but I hope to be able to work on this with you again. 😊 👍

freetomik commented 6 years ago

Hi @james-r-smith, thanks for the fix. I took a quick look on it, and it seems reasonable. :-) I will test it when I will find time and then merge.

I wish I could able to bring this project to some reasonable state, but I am still failing in this. Maybe good New Year’s resolution for me to find time for it.

jameschensmith commented 6 years ago

@freetomik I like that resolution. I'll also pitch in on it. :blush::+1: