mephicide
commented
5 years ago Sure thing!
I assume since the nature of the MessagesClient change impacts existing users, we should communicate that with a major version change. Assuming you agree, I am guessing the new version would be 1.0.0?
I recently participated in a hackathon for my company, and needed the following changes in order to get our demonstration working. Below is a summary of the changes for review. Note, I am using node.js 8.10.0 in my local environment.
Fixing null checks on config loader to properly detect undefined values in config.json, since the proxy value can be omitted rom the file (and was, in my case, having used the yeoman generator).
Retaining base64 encoding on attachments in MessagesClient, so clients can decide whether to convert to ascii or not. Particularly useful for images or other binary content like gzip archives as attachments.
Finally, changing the UsersClient to construct the proper URL query string according to the documentation here (https://rest-api.symphony.com/reference#users-lookup-v3), which requires either an email list or a uid list and never both.
Feel free to suggest an alternate implementation that better fits the overall design of the SDK.