search

SynBioDex / SBOL-specification

The Synthetic Biology Open Language (SBOL)
http://sbolstandard.org
15 stars 9 forks source link

Minor fixes #354

Closed Fontanapink closed 4 years ago

cjmyers commented 4 years ago

A couple minor issues: roles -> role in several places For each activity, let's add the "type" attribute, for example for the first one:

prov:Activity

type: [design] Usage Association etc.

The type should always match the Association role. We should actually check with @bbartley to see if the role on Association is no longer needed.

PrashantVaidyanathan commented 4 years ago

@Fontanapink have the comments been addressed? If so, I'll complete this PR.

Fontanapink commented 4 years ago

I think @cjmyers fixed this in another branch, though I did find some roles and change it to role. Furthermore, Figure 27 (The design/build/test diagram does have roles instead of role and changed it too