search

SynBioDex / SBOL-specification

The Synthetic Biology Open Language (SBOL)
http://sbolstandard.org
14 stars 9 forks source link

Twominorfixes #359

Closed Fontanapink closed 4 years ago

Fontanapink commented 4 years ago

@cjmyers changed Design/build/test UML roles for role. Is that ok?

cjmyers commented 4 years ago

This is good, but we still need to also add a type attribute to each Activity. This should be below the line and above the Usage/Association boxes. It would be:

rdf:type : [design] <-- for first one. In general, should match the Association Role.

PrashantVaidyanathan commented 4 years ago

@Fontanapink Just confirming. Should I go ahead and merge this PR and start a new PR for Chris' comments or do you want to incorporate Chris' comments in this PR?

Fontanapink commented 4 years ago

@PrashantVaidyanathan done!