SBOL 2-3 converter - Interaction (Priority 2)

SynBioDex / SBOL-utilities

Command-line utilities and scripts for manipulating SBOL data

MIT License

12 stars 21 forks source link

SBOL 2-3 converter - Interaction (Priority 2) #248

Open PrashantVaidyanathan opened 5 months ago

manulera commented 4 months ago

Hi @jakebeal,

What is the equivalent for Interaction.functionalComponents from sbol2 in Interaction from sbol3? I have checked the conversion spec, but the only thing I found was:

jakebeal commented 4 months ago

That's odd... an SBOL2 Interaction shouldn't have a functionalComponents member at all.

That looks like a bug to me, since the functional components are included via participations and nowhere in the code is Interaction.functionalComponents actually used.

I would recommend ignoring it and/or setting up a PR to remove it.

tcmitchell commented 4 months ago

pySBOL2 was intended to be (bug-for-bug) compatible with pySBOL and thus libSBOL. libSBOL has a functionalComponents property on Interaction. See https://github.com/SynBioDex/libSBOL/blob/master/source/interaction.h#L49