search

SynBioDex / SBOL-visual

The reference implementation of the SBOL Visual standard
Other
33 stars 16 forks source link

Added the ontology files (RDF and the HTML pages) #75

Closed goksel closed 5 years ago

goksel commented 5 years ago

Added the ontology files for both RDF and HTML versions under the Ontology/v2 folder. We may consider changing the folder structure and perhaps creating the v1 folder for the previous ontology files. The image paths are hardcoded to look into the Master branch and that is why some of the images (the recent ones that are not in master) are not displayed when the HTML page is viewed under the ontology-update branch. This will be fixed when the ontology-branch is merged into master.

I also updated the simple chemical README file so that I could generate three recommended terms.

We can also consider adding github pages to the project so that we can serve the HTML file directly, although the HTML view for the full GitHub page would only be for the Master branch. An example of how this would work is here: https://dissys.github.io/sbol-visual-ontology/sbol-vo.html

goksel commented 5 years ago

Fixed the image ontology assignments for the complex glyphs. This will also be merged as part of this pull request.

jakebeal commented 5 years ago

Three requests before I merge:

  1. Can you please remove the v1 material entirely? It can always be accessed by going to past history if needed, but it is not just obsolete, it's also likely incorrect and/or ill-defined; we simply don't want to support it any more.
  2. We need to have a means for testing and validating the ontology. If that's not simple to add, can you please add an issue?
  3. I very much like your suggestion of serving the pages. Can you please either set that up or else open an issue to do it later?