search

SynBioDex / SBOL-visual

The reference implementation of the SBOL Visual standard
Other
33 stars 16 forks source link

Glyph should have subclasses for the four main types #96

Closed jakebeal closed 3 years ago

jakebeal commented 4 years ago

If one wants to programmatically browse through glyphs, it's useful to be able to separate out the sequence feature glyphs from the molecular species from the interactions and interaction nodes.

As such, we should have subclasses for the four main types of glyph, rather than putting them all together under Glyph.

goksel commented 4 years ago

@jakebeal, I added the four main glyph categories and made a pull request for issue 96. I hope the changes are ok. Please let me know if you are require any changes.

goksel commented 4 years ago

I also added instructions below regarding how to update the ontology and the HTML version: https://dissys.github.io/sbol-visual-ontology

jakebeal commented 4 years ago

Where is that hosted from? I still see the old instructions in the SBOL Visual repository: https://github.com/SynBioDex/SBOL-visual/tree/master/Ontology

On Fri, Oct 2, 2020 at 5:38 AM Goksel Misirli notifications@github.com wrote:

I also added instructions below regarding how to update the ontology and the HTML version: https://dissys.github.io/sbol-visual-ontology

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOL-visual/issues/96#issuecomment-702658371, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACRONO5VYQGAHEJRVPROITLSIWUUBANCNFSM4MMYS3MQ .

goksel commented 4 years ago

@jakebeal, instructions about how to update the ontology is here: https://dissys.github.io/sbol-visual-ontology

jakebeal commented 4 years ago

Right, but I think that it would be a good idea for this all to migrate into community repositories and community websites if it's going to be a long-term community resource. I'll open an issue for this, and hopefully we can sort it out as part of the workflows discussion at COMBINE.

goksel commented 3 years ago

@jakebeal I suggest closing this issue after I move the ontology to SynBioDex.

jakebeal commented 3 years ago

@goksel We also need the pull request addressing this issue (#106) to be able to be resolved, which needs SBO restrictions to get put back on Interactions again. That's what it's been waiting for.

goksel commented 3 years ago

@jakebeal Please close the issue after your merge the pull request https://github.com/SynBioDex/SBOL-visual/pull/133