fix divide by zero when the graph is empty

[oflatt]

Did the build error because I don't have the required docker credentials?

[cjmyers]

@michael13162 can you add Oliver to the repo and help him with docker credentials.

On Feb 28, 2019, at 11:31 AM, Oliver Flatt notifications@github.com wrote:

Did the build error because I don't have the required docker credentials?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/michael13162/SBOLExplorer/pull/40#issuecomment-468384561, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD9yjffwSbX2VUpHg6mWE5f6uG4JJTks5vSCB4gaJpZM4bXbPE.

[michael13162]

Added Oliver to the repo.

The docker username and password are set I believe. Looks like the docker build/push script is hanging on asking for a username because the credential values from the settings aren't being exported? @zachzundel

[3ach]

Yes, Oliver's PR is not given the credentials because they are protected. If not, he could submit a PR that exposed the credentials. We fixed this for SynBioHub by only running the push step on commits to master. @michael13162 : you should be able to figure out the changes necessary by looking at .travis.yml in SynBioHub

[michael13162]

I tried emulating what you have you SynBioHub, but it's still running the push when I retry the build. https://github.com/michael13162/SBOLExplorer/blob/master/.travis.yml

[3ach]

Could the build not be incorporating the commit with your Travis changes since this is a branch and that's master? @oflatt rebasing off of the new tip of master could maybe help

[3ach]

Also, it looks like your changes won't even build on new changes. Really, they should build on all commits/PRs, and only push on master

[oflatt]

for now, I created another pull request #41