search

SynBioDex / SBOLTestSuite

6 stars 10 forks source link

Redundant XML nodes in eukaryotic_transcriptional_unit.xml #1

Open bbartley opened 6 years ago

bbartley commented 6 years ago

It looks like objects http://michael.zhang/Pro_CombinatorialDerivation and http://michael.zhang/Eukaryotic_Transcriptional_Unit_CombinatorialDerivation have redundant prov:wasGeneratedBy nodes, for example:

<prov:wasGeneratedBy rdf:resource="http://michael.zhang/Eukaryotic_Transcriptional_Unit_SBOLDesignerActivity/1"/>
<prov:wasGeneratedBy rdf:resource="http://michael.zhang/Eukaryotic_Transcriptional_Unit_SBOLDesignerActivity/1"/>

This flags a round-trip error with libSBOL, which serializes these as a single node.

michael13162 commented 6 years ago

Thanks for reporting this Bryan. I took a look at the libSBOLj implementation, and wasGeneratedBys is a Set, so it fundamentally can't contain the same URI twice. This is likely a problem with libSBOLj's serialization. For now, I've removed the duplicate lines in the xml file.

cjmyers commented 6 years ago

Not sure how this occurred. Please let us know if you see this again.

On Jan 12, 2018, at 3:07 PM, Michael Zhang notifications@github.com wrote:

Thanks for reporting this Bryan. I took a look at the libSBOLj implementation, and wasGeneratedBys is a Set, so it fundamentally can't contain the same URI twice. This is likely a problem with libSBOLj's serialization. For now, I've removed the duplicate lines in the xml file.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SynBioDex/SBOLTestSuite/issues/1#issuecomment-357367939, or mute the thread https://github.com/notifications/unsubscribe-auth/ADWD9zffWSbojs0Iaao_h5NgcPaf32j7ks5tJ9e8gaJpZM4Rc5Jm.