createRecursiveCopy needs to follow all links

SynBioDex / libSBOLj

Java Library for Synthetic Biology Open Language (SBOL)

Apache License 2.0

37 stars 24 forks source link

createRecursiveCopy needs to follow all links #527

Closed michael13162 closed 6 years ago

michael13162 commented 6 years ago

Specifically, createRecursiveCopy may not be copying over wasDerivedFroms or wasGeneratedBys. As we said though, wasGenereratedBys should be copied over, but one could make the argument that wasDerivedFroms aren't necessary.

Also, Activity's have usages to derivations that are also not being copied. This is necessary for the serialization of combinatorial derivations after enumeration.

cjmyers commented 6 years ago

It is now copying links in wasDerivedFrom/wasGeneratedBy. Links via Entities in Usages already appear to be working.

cjmyers commented 6 years ago

@michael13162 is this working for you now? If so, please close.

michael13162 commented 6 years ago

Confirmed works. Thanks.