search

SynBioDex / libSBOLj

Java Library for Synthetic Biology Open Language (SBOL)
Apache License 2.0
37 stars 24 forks source link

libSBOLj serializes Boolean annotations as strings #565

Open jakebeal opened 5 years ago

jakebeal commented 5 years ago

While annotations retain their types internally, when you send a Boolean annotation to SynBioHub, it comes back as a string. This appears to be due to an issue in libSBOLj serialization, which is not adding the appropriate rdf:datatype annotations.

For example: <ns0:stub_object>true</ns0:stub_object> should instead be: <ns0:stub_object rdf:datatype="http://www.w3.org/2001/XMLSchema#boolean" >true</ns0:stub_object>

When this is resolved, tests should be added to see if this issue is also afflicting other libraries. Likewise, are there other places in SBOL where Booleans are used?

cjmyers commented 5 years ago

I'm not aware of any other booleans in SBOL other than annotations.

jakebeal commented 5 years ago

I thought we'd used them in a property somewhere, but I just went through and find it nowhere except on annotations, so it looks like that's the only place where this is a problem.