search

SynBioDex / pySBOL2

A pure Python implementation of the SBOL standard.
Apache License 2.0
20 stars 6 forks source link

Solving override issue #411

Closed JMante1 closed 2 years ago

JMante1 commented 2 years ago

I think there was a mistake here. Either line 131 should add _seq or line 130 should check SBOL_TYPED_URIS. Otherwise you end up with a warning: An object with this identity is already contained in the Document'

tcmitchell commented 2 years ago

@JMante1 thanks very much for this submission. I do not see a related issue, did I miss it? If there isn't one could you please open an issue that documents and demonstrates the problem you are fixing?

Could you please also provide a test case that fails without your fix and passes when your fix is included?

Thanks!

tcmitchell commented 2 years ago

@JMante1 this PR has been idle for 3 months. I'm guessing you found another workaround. Is this ok to close?

tcmitchell commented 2 years ago

Another 3 months have gone by, and no response to the Jan 11 request for unit test or the April 13 inquiry. I am closing this PR due to lack of activity. Please reopen it when you are ready to continue.