Closed kenza12 closed 2 years ago
@jakebeal can you please test this change in whatever context caused you to add the JAVA_LOCATION
config setting and verify that the new default of java
(instead of /usr/bin/java
) works for you?
If this runs against the test suite, then it should be fine. I don't understand why the pull request actions haven't run here, however.
I pushed a separate branch to test the build and it seems to have worked this time. I suspect the build problem was because our nightly build had been disabled due to a lack of activity in our repo. I re-enabled the builds. I think this PR can be merged.
Thanks @kenza12 !
Hi @tcmitchell @jakebeal ,
This is a pull request where I changed the JAVA path from
/usr/bin/java
tojava
(discussed here: https://github.com/SynBioDex/pySBOL2/issues/417) insbol2/config.py
file. So, I'm trying to update the pysbol2 conda package and this JAVA path/usr/bin/java
is not found by conda even If I added openjdk to conda dependencies, But it's working when I specify onlyjava
.Can you check if this is working in your environment this way and if it's the case, can you add a new tag including these modifications ?
Thank you.
Best wishes,
Kenza BAZI KABBAJ
Closes #419