search

SynBioDex / pySBOL2

A pure Python implementation of the SBOL standard.
Apache License 2.0
20 stars 6 forks source link

Remove functionalComponents property from Interaction #438

Open manulera opened 5 months ago

manulera commented 5 months ago

Related to https://github.com/SynBioDex/SBOL-utilities/issues/248

tcmitchell commented 5 months ago

@jakebeal this will break the intentional bug-for-bug compatibility with pySBOL/libSBOL. libSBOL has a functionalComponents property on Interaction: https://github.com/SynBioDex/libSBOL/blob/master/source/interaction.h#L49

You can remove this property, and you should be aware of the ramifications before doing so.

jakebeal commented 5 months ago

Thanks, @tcmitchell - that's good to know.

Do you think there's a way to support the libSBOL bug while avoiding future confusion by marking it as deprecated or something of the sort?