SynBioDex / pySBOL3

Native python implementation of SBOL 3.0 specification
MIT License
37 stars 16 forks source link

Unprotect sbol3.Identified._extract_display_id? #310

Closed jakebeal closed 2 years ago

jakebeal commented 3 years ago

I have recently used the protected function sbol3.Identified._extract_display_id several times. This seems like a useful utility; is there a reason to keep it protected?

tcmitchell commented 3 years ago

If sbol3.Identified._extract_display_id were to be made public, it needs to be carefully documented so user's know what they're getting into when they use it. I have no objection to making sbol3.Identified._extract_display_id public. We can consider whether it should remain a static method of Identified, or if it should be a top level function of sbol3 (i.e. sbol3.extract_display_id).

jakebeal commented 3 years ago

I'm essentially using it as a helper function, so I'd be find with either place.