SynBioDex / pySBOL3

Native python implementation of SBOL 3.0 specification
MIT License
37 stars 16 forks source link

Write unit test for feature.py validate function #420

Closed Omarelsherif010 closed 1 year ago

Omarelsherif010 commented 1 year ago

Hi @tcmitchell,

I have been working through current tests to make sure they apply all validation rules that are already implemented in the validation function inside classes, I noticed that feature class validate function doesn't have a unit test for its validation function so I am asking to start working on implementing this in preparation to work on "Implement pySBOL3 Validation Rules" project in GSoC.

I followed Jake's recommendation on preparation. After reading SBOL Specification for Sequence class Page 70, I have created sbol file to test different cases of validation function in sequence class. link to my fork (contains the file)

test_validation_sequence_rules

Then I checked the location class and feature class and noticed that the feature class doesn't have a unit test for its validation function. I remember you are using Test Driven Development in building the library so I plan to use it while implementing validation rules that have not yet been implemented.

Do you recommend coding that unit test for the feature class validation function? or is there something better to do in preparation to implement other rules?

tcmitchell commented 1 year ago

@Omarelsherif010 yes, adding a unit test is a good first step towards implementing validation checks for the Feature class. I will be happy to answer further questions, but my replies may be a little bit slow. I'm sorry in advance for the delays in responding to you.

tcmitchell commented 1 year ago

Closed by #426