SynBioDex / pySBOL3

Native python implementation of SBOL 3.0 specification
MIT License
37 stars 16 forks source link

Unittest feature class validation update #426

Closed Omarelsherif010 closed 1 year ago

Omarelsherif010 commented 1 year ago

added .vscode to .gitignore file and now working on the unittest itself

Omarelsherif010 commented 1 year ago

something wrong happened, and I am trying to figure it out. Skip my commits for today, I will come back the right files

Omarelsherif010 commented 1 year ago

Now we detect the correct orientation for the feature class and ensure the validate function works well. (check last commit)

For now, the validate function checks on the orientation. What else should we test inside the unit test to make the feature valid?

I thought about testing roles inside the validate function and checking them inside the unit test!!

What do you think?

Note: I have closed PR #422 during solving vscode files problem

Omarelsherif010 commented 1 year ago

fixes #420