Reuse identical graphics

SynBioDex / sbol_factory

The SBOLFactory provides a mechanism for automatically generating an interactive, object-oriented API from a declarative data model specification encoded in OWL.

MIT License

6 stars 3 forks source link

Reuse identical graphics #46

Closed jakebeal closed 3 years ago

jakebeal commented 3 years ago

Sibling and child classes in hierarchies share the same graphic. Rather than repeating the graphic, it would be good to consolidate it to the root class and have them all point to the same one.

A good cut-point for this would be on the lines of clusters (#45)

bbartley commented 3 years ago

First, can you confirm that this is actually the behavior we desire? By point of comparison, I don't think the SBOL spec reuses identical diagrams for different classes. For example, I don't think sibling classes share the same diagram. The identical graphics are an artifact of how UMLFactory is currently configured, which could be tweaked to produce diagrams more consistent with conventions used in the SBOL spec.

jakebeal commented 3 years ago

This is how the SBOL specification works for anything that has subclasses besides Identified and Toplevel - there just aren't many cases of that in SBOL vs. in UML and PAML. In the SBOL3 spec it is handled this way for:

Feature (Figure 9)
Location (Figure 10)

which are the only two non-root classes with subclasses